Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changeset for #6148 #6198

Merged
merged 5 commits into from
Jun 29, 2023
Merged

Add changeset for #6148 #6198

merged 5 commits into from
Jun 29, 2023

Conversation

tremarkley
Copy link
Contributor

@tremarkley tremarkley commented Jun 29, 2023 •
edited
Loading

#6148 changed the the build directory for the contracts-bedrock package. This is causing the most recent canary release of the sdk to not build properly:

Error: Cannot find module '@eth-optimism/contracts-bedrock/forge-artifacts/L1StandardBridge.sol/L1StandardBridge.json'
Require stack:
- /__w/gateway/gateway/node_modules/.pnpm/@[email protected][email protected]/node_modules/@eth-optimism/sdk/dist/utils/contracts.js
- /__w/gateway/gateway/node_modules/.pnpm/@[email protected][email protected]/node_modules/@eth-optimism/sdk/dist/utils/index.js
- /__w/gateway/gateway/node_modules/.pnpm/@[email protected][email protected]/node_modules/@eth-optimism/sdk/dist/index.js
- /__w/gateway/gateway/packages/common-ts/build/index.js
- /__w/gateway/gateway/packages/frontend/e2e/tests/bridge.spec.ts
- /__w/gateway/gateway/node_modules/.pnpm/@[email protected]/node_modules/@playwright/test/lib/loader.js
- /__w/gateway/gateway/node_modules/.pnpm/@[email protected]/node_modules/@playwright/test/lib/runner.js
- /__w/gateway/gateway/node_modules/.pnpm/@[email protected]/node_modules/@playwright/test/lib/cli.js
- /__w/gateway/gateway/node_modules/.pnpm/[email protected]/node_modules/playwright-core/lib/cli/cli.js
- /__w/gateway/gateway/node_modules/.pnpm/[email protected]/node_modules/playwright-core/cli.js
- /__w/gateway/gateway/node_modules/.pnpm/@[email protected]/node_modules/@playwright/test/cli.js

   at ../../../node_modules/.pnpm/@[email protected][230](https://github.com/ethereum-optimism/gateway/actions/runs/5415046723/jobs/9842944650?pr=2310#step:6:231)[email protected]/node_modules/@eth-optimism/sdk/src/utils/contracts.ts:3

@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 545f246

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@eth-optimism/contracts-bedrock Patch
@eth-optimism/core-utils Patch
@eth-optimism/sdk Patch
@eth-optimism/chain-mon Patch
@eth-optimism/common-ts Patch
@eth-optimism/replica-healthcheck Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tremarkley tremarkley requested a review from tynes June 29, 2023 18:02
@netlify
Copy link

netlify bot commented Jun 29, 2023 •
edited
Loading

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 545f246
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/649dcba00dc67600082d3286

@tynes tynes merged commit 9a37b53 into develop Jun 29, 2023
@tynes tynes deleted the 6148_changeset branch June 29, 2023 18:24
This was referenced Jul 18, 2023
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurelian maurelian maurelian approved these changes

@tynes tynes tynes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremarkley @tynes @maurelian